Use one NavHost (with a single navigation scaffold) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the app had a NavHost but didn't actually call navigate. NavHost's startDestination was read from external state (the currently selected nav item), which led to some undesirable behaviors. - NavHost itself was recomposed when selecting a nav item. - Pressing back always exited the app because you were always at the start destination. Now the NavHost has a stable startDestination, and nav item state is driven by the NavHostController's current destination. Selecting a nav item calls navigate, and the user always goes back through the startDestination before exiting the app.
alexvanyo
reviewed
Sep 25, 2024
gradle/libs.versions.toml
Outdated
| ksp = "2.0.0-1.0.21" | ||
| lifecycle = "2.8.4" | ||
| material3 = "1.2.1" | ||
| media3 = "1.4.1" | ||
| navigation = "2.7.7" | ||
| navigation = "2.8.0-rc01" |
There was a problem hiding this comment.
Nit: since 2.8.1 is released, can we use that?
dturner
reviewed
Sep 26, 2024
Base automatically changed from
jdk/codelab_2024_fixup
to
codelab_improve_android_experience_2024
October 2, 2024 17:07
…ce_2024' into jdk/one_nav_host__single_nav_scaffold
dturner
approved these changes
Oct 14, 2024
alexvanyo
approved these changes
Oct 14, 2024
jdkoren
merged commit 328dcc6
into
codelab_improve_android_experience_2024
2 checks passed
ashnohe
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Deduplicate lifecycle runtime compose * kotlin 2.0 and compose gradle plugin * update test & other versions * Call navigate instead of recomposing HavHost Previously, the app had a NavHost but didn't actually call navigate. NavHost's startDestination was read from external state (the currently selected nav item), which led to some undesirable behaviors. - NavHost itself was recomposed when selecting a nav item. - Pressing back always exited the app because you were always at the start destination. Now the NavHost has a stable startDestination, and nav item state is driven by the NavHostController's current destination. Selecting a nav item calls navigate, and the user always goes back through the startDestination before exiting the app. * Use type-safe navigation * Make a package for navigation routes * Migrate to type safe routes for main navhost * Push Scaffold down to each top-level destination * Extract nav suite scaffold to another composable * Move ChatList, move and rename HomeViewModel * Move Settings to its own package * Remove Home and put its destinations in Main NavHost * Remove Home composable and rename file * Add NavigationSuiteScaffold around NavHost * Change navigation layout type based on current destination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates all the navigation into one NavHost. A single NavigationSuiteScaffold is used to show top-level routes, with logic to hide some or all forms of navigation based on the current destination.
Fixes #96.